Feat(web-react): Uncontrolled Pagination component #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spirit-design-system-demo canceled.
|
✅ Deploy Preview for spirit-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
literat
force-pushed
the
docs/remove-storybook-plugin
branch
from
5bae716 to
4e671af
Compare
literat
force-pushed
the
feat/web-react-uncontrolled-pagination
branch
from
8e198f9 to
8551772
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7139642. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-validations canceled.
|
crishpeen
reviewed
Oct 24, 2023
packages/web-react/src/components/Pagination/__tests__/UncontrolledPagination.test.tsx
Outdated
Show resolved
Hide resolved
|
Discussed the suggestion offline with @crishpeen and refactored it. |
literat
force-pushed
the
feat/web-react-uncontrolled-pagination
branch
2 times, most recently
from
cc851d2 to
718ca08
Compare
crishpeen
approved these changes
Oct 24, 2023
packages/web-react/src/components/Pagination/UncontrolledPagination.tsx
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/Pagination/UncontrolledPagination.tsx
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/Pagination/__tests__/UncontrolledPagination.test.tsx
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/Pagination/stories/UncontrolledPagination.stories.tsx
Outdated
Show resolved
Hide resolved
literat
force-pushed
the
feat/web-react-uncontrolled-pagination
branch
from
a203f34 to
7139642
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I am introducing a new Pagination component.
Additional context
Based on #738
Issue reference
Before submitting the PR, please make sure you do the following
fixes #123).